refactor: Don't use the cursor to find connection positions. #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rachel-fenichel
approved these changes
May 13, 2025
Collaborator
rachel-fenichel
left a comment
rachel-fenichel
left a comment
There was a problem hiding this comment.
Approved; please file an issue to take another look at the search code to see if we can use the connection db instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem that would be introduced by RaspberryPiFoundation/blockly#9030: since the cursor won't visit connections, using the cursor to find connections when inserting a block no longer works. Instead, connections are just queried for directly.